-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LINDAT/CLARIAH-CZ #60
Comments
Maybe we should take it step by step. To see how a release is done (see README), how the tests are behaving etc. Starting with just the footer. The end result in https://github.com/ufal/lindat-common/tree/releases branch are html snippets and angular-lindat.js. |
@EbrithilNogare Je mozne nekde header a footer z lindat.cz dostat jako "partial html" snippet? Nejak bychom to do te releases branch dotlacili vedle toho, co tam je ted. At muzou novy projekty includnout rovnou novej header/footer |
I made a quick attempt at providing a header and footer, by just copying the outer HTML of the two related elements from lindat.cz, as well as the generated CSS file. The http://lindat.mff.cuni.cz/#search type links happily work, but I did not test all the things; the header in its current form only works inside the LINDAT domain due to relative links, and there might be other things to correct, but it should be a decent start; I would probably also provide a "narrow" version of the header since the current one takes up quite a bit of space, which for various services is an issue (including TEITOK) since it eats away at screen realestate. The three files are here: http://lindat.mff.cuni.cz/services/teitok/testproject/common/ - inside a project that also uses them (http://lindat.mff.cuni.cz/services/teitok/testproject/index.php) |
I now implemented a draft for 3 different headers, in a branch "newheader" - and there is a test of the output (in TEITOK) here : http://quest.ms.mff.cuni.cz/teitok-dev/teitok/lindattest/index.php |
The logos in the light style have to be different from those in the dark style - I managed to find appropriate transparent versions of all the logos minus the K-Center logo, which CLARIN seems to have removed from its site; they are all linked to live external pages, so they should be copied to a local directory somewhere, what would be the correct place for that? |
There are various disadvantageous for a tool like TEITOK, or most of the other tools, in using the standard header and footer from the newheader files - but all of those can be overruled by a local CSS declaration (these have been applied to the TEITOK templates, so it uses the standard header and footer but overrules some of the standard declarations):
|
just a note added the files here https://github.com/ufal/lindat-common/tree/5c9edc11b24279f5b6ac943f02527d8a2d37c8cb/new_theme and when the ci is finished it will end up in releases branch in https://github.com/ufal/lindat-common/tree/4dc30d50fd2696874bc70b12ac3846c4e88d8dac/new_theme; I've modified the footers a bit - adding the tracking code; we need that to generate statistics (but there's also #63 ) One remark - the files (light/dark) don't differ too much in content (is it only the logos?); so we should find a way to somehow externalize the difference; so there's just one file to modify when a change is needed one rather annoying thing is that travis-ci.org now take some 3-4 hrs to run (used to be in minutes; dont' know if it's due to some issue on their site or due to the announced migration from org to com) |
8af2fc0 introduces another option of including the header and footer (dark, for now);...when it gets compiled and into releases branch:
issues mentioned by maarten, eg. position static, would need some extra effort to get sorted; again the advantage being that it does not clash with the css of the application including the header/footer. btw @maartenpt I've noticed the header is missing the "tagline" ("Digital Research Infrastructure for the Language Technologies, Arts and Humanitiessupported by"); is that intentional? |
The tagline is not a static part of the header - I first thought so as well, but it is only there on the first page, it scrolls away.... |
new theme released as https://github.com/ufal/lindat-common/releases/tag/v3.0.1 |
The text was updated successfully, but these errors were encountered: