Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LINDAT/CLARIAH-CZ #60

Closed
stranak opened this issue Dec 10, 2020 · 10 comments
Closed

Update to LINDAT/CLARIAH-CZ #60

stranak opened this issue Dec 10, 2020 · 10 comments
Assignees

Comments

@stranak
Copy link
Member

stranak commented Dec 10, 2020

  • copy the footer from lindat.cz
  • not sure about copying the contents of the top menu (it has no direct links to any services), but definitely needs CLARIN and DARIAH hi-res logos
  • not quite sure whether the dark blue look can work for all services
    • maybe include both the old style and new and make them selectable (if possible)?
@kosarko
Copy link
Member

kosarko commented Dec 11, 2020

Maybe we should take it step by step. To see how a release is done (see README), how the tests are behaving etc. Starting with just the footer. The end result in https://github.com/ufal/lindat-common/tree/releases branch are html snippets and angular-lindat.js.
The angular components are used at least by pmltq and treex-web.
The sources are https://github.com/ufal/lindat-common/blob/master/src/partials/footer.html , https://github.com/ufal/lindat-common/blob/master/src/partials/footer.en.yml , https://github.com/ufal/lindat-common/blob/master/src/partials/footer.cs.yml. Be sure to leave the tracking codes and data-version in the footer.
It should be testable locally (you might need to update the selenium driver, depending on browser version check the commits history https://github.com/ufal/lindat-common/commits;).
As for automatic updates, when there's a release, repository should eventually pull the changes (but we can do it manually); some other sevices need to be rebuild.

@kosarko
Copy link
Member

kosarko commented Jan 28, 2021

@EbrithilNogare Je mozne nekde header a footer z lindat.cz dostat jako "partial html" snippet? Nejak bychom to do te releases branch dotlacili vedle toho, co tam je ted. At muzou novy projekty includnout rovnou novej header/footer

@maartenpt
Copy link
Contributor

I made a quick attempt at providing a header and footer, by just copying the outer HTML of the two related elements from lindat.cz, as well as the generated CSS file. The http://lindat.mff.cuni.cz/#search type links happily work, but I did not test all the things; the header in its current form only works inside the LINDAT domain due to relative links, and there might be other things to correct, but it should be a decent start; I would probably also provide a "narrow" version of the header since the current one takes up quite a bit of space, which for various services is an issue (including TEITOK) since it eats away at screen realestate. The three files are here: http://lindat.mff.cuni.cz/services/teitok/testproject/common/ - inside a project that also uses them (http://lindat.mff.cuni.cz/services/teitok/testproject/index.php)

@maartenpt
Copy link
Contributor

I now implemented a draft for 3 different headers, in a branch "newheader" - and there is a test of the output (in TEITOK) here : http://quest.ms.mff.cuni.cz/teitok-dev/teitok/lindattest/index.php

@maartenpt
Copy link
Contributor

maartenpt commented Jan 29, 2021

The logos in the light style have to be different from those in the dark style - I managed to find appropriate transparent versions of all the logos minus the K-Center logo, which CLARIN seems to have removed from its site; they are all linked to live external pages, so they should be copied to a local directory somewhere, what would be the correct place for that?

@maartenpt
Copy link
Contributor

maartenpt commented Jan 29, 2021

There are various disadvantageous for a tool like TEITOK, or most of the other tools, in using the standard header and footer from the newheader files - but all of those can be overruled by a local CSS declaration (these have been applied to the TEITOK templates, so it uses the standard header and footer but overrules some of the standard declarations):

  1. .navbar { position: static; }
  • prevent the top bar to stay on screen when scrolling so that it no longer eats up screen real estate
  1. #ack-freepik { display: none; }
  2. #ack-ufal { display: none; }
  • the two acknowledgment lines on the bottom of the header only apply to the LINDAT site, not to the services, so those can just be hidden
  1. .language-switcher-language-url { visibility: hidden; }
  • the language pulldown switch will not work in most of the services this way - so best to hide this one and replace it by the tool-internal language selection option

@kosarko
Copy link
Member

kosarko commented Jan 30, 2021

just a note added the files here https://github.com/ufal/lindat-common/tree/5c9edc11b24279f5b6ac943f02527d8a2d37c8cb/new_theme and when the ci is finished it will end up in releases branch in https://github.com/ufal/lindat-common/tree/4dc30d50fd2696874bc70b12ac3846c4e88d8dac/new_theme;

I've modified the footers a bit - adding the tracking code; we need that to generate statistics (but there's also #63 )

One remark - the files (light/dark) don't differ too much in content (is it only the logos?); so we should find a way to somehow externalize the difference; so there's just one file to modify when a change is needed

one rather annoying thing is that travis-ci.org now take some 3-4 hrs to run (used to be in minutes; dont' know if it's due to some issue on their site or due to the announced migration from org to com)

@kosarko
Copy link
Member

kosarko commented Feb 1, 2021

8af2fc0 introduces another option of including the header and footer (dark, for now);...when it gets compiled and into releases branch:

including lindat.js should allow you to use the following tags:

<lindat-header></lindat-header>
<lindat-footer></lindat-footer>

those will get replaced with content matching {header,footer}-dark.htm,
they include https://lindat.mff.cuni.cz/common/new_theme/public/css/lindat-dark.css

The tracking codes should be roughly equivalent; though there's no
noscript option.

about dropdown doesn't work; language dropdown doesn't work (probably
not even in the original .htm files)

The main advantage of this approach is the css doesn't leak into the
including application.

see index.html for usage demo.

issues mentioned by maarten, eg. position static, would need some extra effort to get sorted; again the advantage being that it does not clash with the css of the application including the header/footer.

btw @maartenpt I've noticed the header is missing the "tagline" ("Digital Research Infrastructure for the Language Technologies, Arts and Humanitiessupported by"); is that intentional?

@maartenpt
Copy link
Contributor

The tagline is not a static part of the header - I first thought so as well, but it is only there on the first page, it scrolls away....

@kosarko
Copy link
Member

kosarko commented Oct 12, 2021

new theme released as https://github.com/ufal/lindat-common/releases/tag/v3.0.1

@kosarko kosarko closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants