Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPS4 Does not take into account the initial reel speed #99

Open
dvanwolffelaar opened this issue Dec 6, 2024 · 3 comments
Open

KPS4 Does not take into account the initial reel speed #99

dvanwolffelaar opened this issue Dec 6, 2024 · 3 comments
Labels
enhancement New feature or request KPS4 priority to be fixed first

Comments

@dvanwolffelaar
Copy link
Collaborator

The set initial reel speed from the settings is not taken into account by the find_steady_state!() function of the KPS4. Adding this would allow for better tuning tests.

@dvanwolffelaar
Copy link
Collaborator Author

On this line should this not then be
res1, res2 = vcat(reduce(vcat, res1_), [s.l_tether, s.set.v_reel_out]), vcat(reduce(vcat, res2_),[0,0])

@ufechner7
Copy link
Owner

ufechner7 commented Dec 6, 2024

Why do you think this would be useful? For which kind of test cases would this be needed?

@dvanwolffelaar
Copy link
Collaborator Author

I want to compare the simulation with some real measurements. These might be approximately stable, but I have not yet found cases where the reel speed is 0. Allowing to initialise with a value will allow for better force comparisons.

@ufechner7 ufechner7 added the priority to be fixed first label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request KPS4 priority to be fixed first
Projects
None yet
Development

No branches or pull requests

2 participants