-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling #2104
Conversation
@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there. |
@jkbk2004 This PR branch and all its submodules have been synced with their corresponding ufs-weather-model develop branch. Thanks! |
A quick follow-up is that, the full RT set went through on WCOSS2 successfully, confirming no answer changing for the baseline. Meanwhile, a note is that, the gnv1_nested_intel test failed in the first try during result checking/comparing against baseline, however the second try of the gnv1_nested_intel test succeeded without issues. Another note is that, I encountered the similar issue (first try failed, second run succeeded) for this gnv1_nested_intel test while testing another PR branch. With that, I think this PR/branch is ready to proceed for next steps. Thanks! |
@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test). |
@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now. |
Thanks, @zach1221! |
@DeniseWorthen Have you started the runs? I can do it. |
No, I have not started RTs (didn't think I needed to). |
@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks! |
Yes, I have them going. A little more than halfway there. |
@binli2337 fyi, we're going to work PR #2098 currently and will work this one afterwards. |
Hera logs attached. No changes. |
@binli2337 can you please sync up your branch here? We'll begin testing against this PR next. |
…-weather-model into feature/update_ssc
@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks! |
Hi, @BinLiu-NOAA sorry for the late reply. Yes, the tests are running. We're working to get them finished as soon as possible. Brian should be taking care of WCOSS tests. |
In addition to |
Much appreciated, @zach1221, @FernandoAndrade-NOAA, @BrianCurtis-NOAA! Hopefully, the RTs will go through smoothly. Thanks! |
Regression testing is complete. We can proceed with the merging process on ccpp-physics and cubed-sphere. |
@binli2337 cmeps is merged 8cd4a32 |
@binli2337 fv3atm is merged now as well. NOAA-EMC/fv3atm@8db821c |
@zach1221 I will merge FV3 now. |
It is ready for review. Thanks! |
Commit Queue Requirements:
PR Information
Description
This PR adds capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling.
Commit Message
Enable the capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling. A namelist option is added to control whether or not to use this feature (default is off). Fixes #1975
Co-authored by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA
Priority
Blocking Dependencies
Git Issues Fixed By This PR
Changes
Subcomponent (with links)
Input data
Regression Tests:
FAILED REGRESSION TESTS
Libraries
Testing Log: