-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supplementary physics updates for RRFS code freeze #161
Conversation
@grantfirl @Qingfu-Liu Since this pr is priority, can we ask to review for the update? @haiqinli Once the remarks and updates are approved, it might be helpful to mark out resolved. |
@jkbk2004 I re-reviewed. @haiqinli Please see the comment about your new |
@haiqinli Is it possible to make a quick follow-up? If possible, we like to proceed to commit the pr today or tomorrow. |
@jkbk2004 I am working on it, and will update soon. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haiqinli and other authors!
@jkbk2004 This PR is reviewed and approved, so ready for testing as soon as all branches are updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Just a few requested changes wrt precision.
@@ -3864,25 +3866,18 @@ SUBROUTINE mym_condensation (kts,kte, & | |||
!Add condition for falling/settling into low-RH layers, so at least | |||
!some cloud fraction is applied for all qc, qs, and qi. | |||
rh_hack= rh(k) | |||
wt2 = min(max( zagl - pblh2, 0.0 )/300., 1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to min(max( zagl - pblh2, 0._kind_phys )/300., 1._kind_phys)
@@ -3994,7 +3989,7 @@ SUBROUTINE mym_condensation (kts,kte, & | |||
fac_damp = min(zagl * 0.0025, 1.0) | |||
!cld_factor = 1.0 + fac_damp*MAX(0.0, ( RH(k) - 0.75 ) / 0.26 )**1.9 !HRRRv4 | |||
!cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.25 )**2, 0.3) | |||
cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.145)**2, 0.35) | |||
cld_factor = 1.0 + fac_damp*min((max(0.0, ( RH(k) - 0.92 )) / 0.145)**2, 0.37) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace w/ fac_damp*min((max(0._kind_phys, ( RH(k) - 0.92 )) / 0.145)**2, 0.37_kind_phys)
INTEGER, DIMENSION(ims:ime, jms:jme), INTENT (OUT) :: k_min, k_max ! Min and max ver. levels for BB injection spread | ||
REAL, DIMENSION(ims:ime, jms:jme), INTENT (OUT) :: uspdavg2, hpbl_thetav2 ! SRB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be REAL(kind_phys)
@dustinswales These changes might need to wait until the next round of changes. I think that this has already been combined with #94 and they're doing final RTs. |
@grantfirl Snap, I'm too late! |
We will file a git issue to bring it with next PR. |
This is a supplementary physics updates (MYNN, GF, RUC_LSM, smoke and dust) PR for RRFS code freeze.