[production/RRFS.v1] add a new parameter to control if G-F cold starts or not #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiliDong-NOAA
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
|
@JiliDong-NOAA @MatthewPyle-NOAA We were under the impression that the production/RRFS.v1 branch wasn't receiving any new development. Is this work really supposed to target that branch? |
|
@grantfirl Things are a bit up in the air with RRFSv1, so this PR is intended for this branch, to open possibilities to use a different convective parameterization. Thanks for checking! |
3 tasks
grantfirl
approved these changes
Aug 23, 2024
Qingfu-Liu
approved these changes
Aug 27, 2024
|
@grantfirl @dustinswales @rhaesung @MatthewPyle-NOAA All tests ran ok at ufs-community/ufs-weather-model#2405. This pr can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After RRFS cycled DA switched to using saSAS, REFS members using G-F convection failed due to missing restarting variables. This PR will add a new parameter to control whether G-F will be cold started or not. The parameter will be set to false by default and won't affect any existing code logic/structure.