Updates for component land model #94
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -633,6 +633,20 @@ | |
| dimensions = () | ||
| type = logical | ||
| intent = in | ||
| [cpllnd] | ||
| standard_name = flag_for_land_coupling | ||
|
There was a problem hiding this comment. We've been moving to There was a problem hiding this comment. @grantfirl That is fine. I could fix them at least for land component coupling related once. When I look at to the examples for it, I found There was a problem hiding this comment. Ya, I was talking about standard names only. I think that the variable names in the code are fine and the CCPP doesn't care. But, like I said, I wouldn't worry about changing it now since there is a lot of cleanup in other places to do anyway. The comment was more for the future, if you're going to be adding more on/off logicals, I think that having the standard names start with There was a problem hiding this comment. @grantfirl Okay. I am not doing those changes at this point. Thanks. |
||
| long_name = flag controlling cpllnd collection (default off) | ||
| units = flag | ||
| dimensions = () | ||
| type = logical | ||
| intent = in | ||
| [cpllnd2atm] | ||
| standard_name = flag_for_one_way_land_coupling_to_atmosphere | ||
| long_name = flag controlling land coupling to the atmosphere (default off) | ||
| units = flag | ||
| dimensions = () | ||
| type = logical | ||
| intent = in | ||
| [weasd] | ||
| standard_name = water_equivalent_accumulated_snow_depth_over_land | ||
| long_name = water equiv of acc snow depth over land | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| !> \file sfc_land.F90 | ||
| !! This file contains the code for coupling to land component | ||
|
|
||
| !> This module contains the CCPP-compliant GFS land post | ||
| !! interstitial codes, which returns updated surface | ||
| !! properties such as latent heat and sensible heat | ||
| !! provided by the component version of land model | ||
|
|
||
| !> This module contains the CCPP-compliant GFS land scheme. | ||
| module sfc_land | ||
|
|
||
| use machine, only : kind_phys | ||
|
|
||
| contains | ||
|
|
||
| !> \defgroup sfc_land for coupling to land | ||
| !! @{ | ||
| !! \section diagram Calling Hierarchy Diagram | ||
| !! \section intraphysics Intraphysics Communication | ||
| !! | ||
| !> \brief Brief description of the subroutine | ||
| !! | ||
| !! \section arg_table_sfc_land_run Arguments | ||
| !! \htmlinclude sfc_land_run.html | ||
| !! | ||
|
|
||
| !! | ||
| !! \section general General Algorithm | ||
| !! \section detailed Detailed Algorithm | ||
| !! @{ | ||
| subroutine sfc_land_run(im, cpllnd, cpllnd2atm, flag_iter, dry, & | ||
| sncovr1_lnd, qsurf_lnd, evap_lnd, hflx_lnd, & | ||
| ep_lnd, t2mmp_lnd, q2mp_lnd, gflux_lnd, & | ||
| runoff_lnd, drain_lnd, cmm_lnd, chh_lnd, zvfun_lnd, & | ||
| sncovr1, qsurf, evap, hflx, ep, t2mmp, q2mp, & | ||
| gflux, runoff, drain, cmm, chh, zvfun, & | ||
| errmsg, errflg) | ||
|
|
||
| implicit none | ||
|
|
||
| ! Inputs | ||
| integer , intent(in) :: im | ||
| logical , intent(in) :: cpllnd | ||
| logical , intent(in) :: cpllnd2atm | ||
| logical , intent(in) :: flag_iter(:) | ||
| logical , intent(in) :: dry(:) | ||
| real(kind=kind_phys), intent(in) :: sncovr1_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: qsurf_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: evap_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: hflx_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: ep_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: t2mmp_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: q2mp_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: gflux_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: runoff_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: drain_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: cmm_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: chh_lnd(:) | ||
| real(kind=kind_phys), intent(in) :: zvfun_lnd(:) | ||
| ! Inputs/Outputs | ||
| real(kind=kind_phys), intent(inout) :: sncovr1(:) | ||
| real(kind=kind_phys), intent(inout) :: qsurf(:) | ||
| real(kind=kind_phys), intent(inout) :: evap(:) | ||
| real(kind=kind_phys), intent(inout) :: hflx(:) | ||
| real(kind=kind_phys), intent(inout) :: ep(:) | ||
| real(kind=kind_phys), intent(inout) :: t2mmp(:) | ||
| real(kind=kind_phys), intent(inout) :: q2mp(:) | ||
| real(kind=kind_phys), intent(inout) :: gflux(:) | ||
| real(kind=kind_phys), intent(inout) :: runoff(:) | ||
| real(kind=kind_phys), intent(inout) :: drain(:) | ||
| real(kind=kind_phys), intent(inout) :: cmm(:) | ||
| real(kind=kind_phys), intent(inout) :: chh(:) | ||
| real(kind=kind_phys), intent(inout) :: zvfun(:) | ||
| ! Outputs | ||
| character(len=*) , intent(out) :: errmsg | ||
| integer , intent(out) :: errflg | ||
|
|
||
| ! Locals | ||
| integer :: i | ||
|
|
||
| ! Initialize CCPP error handling variables | ||
| errmsg = '' | ||
| errflg = 0 | ||
|
|
||
| ! Check coupling from component land to atmosphere | ||
| if (.not. cpllnd2atm) return | ||
|
|
||
| ! Fill variables | ||
| do i = 1, im | ||
| sncovr1(i) = sncovr1_lnd(i) | ||
| qsurf(i) = qsurf_lnd(i) | ||
| hflx(i) = hflx_lnd(i) | ||
| evap(i) = evap_lnd(i) | ||
| ep(i) = ep_lnd(i) | ||
| t2mmp(i) = t2mmp_lnd(i) | ||
| q2mp(i) = q2mp_lnd(i) | ||
| gflux(i) = gflux_lnd(i) | ||
| drain(i) = drain_lnd(i) | ||
| runoff(i) = runoff_lnd(i) | ||
| cmm(i) = cmm_lnd(i) | ||
| chh(i) = chh_lnd(i) | ||
| zvfun(i) = zvfun_lnd(i) | ||
| enddo | ||
|
|
||
| end subroutine sfc_land_run | ||
|
|
||
| !> @} | ||
| end module sfc_land |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uturuncoglu Since you're adding yourself to the CODEOWNERS, please accept the collaboration invitation for this repository that I just sent you so that you will be added as a reviewer automatically when these files are touched in a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grantfirl Sorry. I did not do it intentionally. I was just trying to follow the conventions in there. Since I am not doing to much development in CCPP side, you could remove me from the list. That is totally fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uturuncoglu IMO, it's totally appropriate to add you since you're adding these files to the repository. If @barlage is OK with being the CODEOWNER by himself, that is OK too. I'll let you two decide what you'd prefer.