fix NSSL MP init issue when initialized from other microphysics schemes

[JiliDong-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This is the fix from Ted Mansell @MicroTed on NSSL MP initialization to check if there is missing number of concentration for any non-zero hydrometers mixing ratio. NSSL MP will calculate N from mixing ratio in the first timestep if missing value is found. This fix will guarantee that NSSL MP enters the correct warm/cold start initializations.

Commit Message

fix NSSL MP init issue when initialized from other microphysics schemes

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
• Normal

Blocking Dependencies

• Fix NSSL MP init issue when initialized from other microphysics schemes NOAA-EMC/fv3atm#764
• fix NSSL MP init issue when initialized from other microphysics schemes ccpp-physics#157

Git Issues Fixed By This PR

#2100

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• Fix NSSL MP init issue when initialized from other microphysics schemes NOAA-EMC/fv3atm#764
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

FAILED REGRESSION TESTS

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[JiliDong-NOAA]

RegressionTests_hera.log

[jkbk2004]

@JiliDong-NOAA can you sync up branches? Once branches are synced up, I will try to follow up to combine this PR to #2104 at physics PR level.

[JiliDong-NOAA]

@JiliDong-NOAA can you sync up branches? Once branches are synced up, I will try to follow up to combine this PR to #2104 at physics PR level.

Thanks. All submodules synced up.

[BrianCurtis-NOAA]

@JiliDong-NOAA EPIC would like to get to this PR next. Once a merge of the current UFSWM PR completes, please make sure that you updates hashes from FV3 once that is updated.

[zach1221]

@JiliDong-NOAA Please sync up your branch. We'd like to begin testing against this PR.

[JiliDong-NOAA]

@JiliDong-NOAA Please sync up your branch. We'd like to begin testing against this PR.

Done.

[zach1221]

@BrianCurtis-NOAA I think we're ready to work this PR. I'm going to start my tests.

[zach1221]

Hercules is being a bit slow today. One test left pending, but it may be a while longer.

[zach1221]

Testing is complete. Let's begin with the merging process on ccpp-physics #157

[JiliDong-NOAA]

.gitmodules reverted and FV3 updated

[zach1221]

@JiliDong-NOAA fv3atm PR is merged. Please update the submodule hash and revert the change in .gitmodule url.
hash: NOAA-EMC/fv3atm@ef04de2

[JiliDong-NOAA]

@JiliDong-NOAA fv3atm PR is merged. Please update the submodule hash and revert the change in .gitmodule url. hash: NOAA-EMC/fv3atm@ef04de2

Done.