Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKEB fix with d_con = zero #2374

Closed

Conversation

NeilBarton-NOAA
Copy link
Collaborator

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

The dyn_core fails when d_con is zero and skeb is True because heat_source is unallocated. This change allocates heat_source when skeb is True and d_con is zero.

* UFSWM - 
   * FV3 - 
    * atmos_cubed_sphere - 

Priority:

  • Critical Bugfix: SFS model fails with SKEB when d_con is zero

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@NeilBarton-NOAA NeilBarton-NOAA changed the title Skeb fix SKEB fix with d_con = zero Jul 19, 2024
zach1221 pushed a commit that referenced this pull request Aug 12, 2024
… FV3 diag table documentation #2277 + SKEB fix with d_con = zero #2374 (#2278)

* UFSWM - python scripts for yaml and rocoto-xml conversion, experiment setup, and test log output  
* Add python superlint option
* Documentation update: doc/UsersGuide/source/tables/fv3_diag_table.rst
    * FV3 - 
    * atmos_cubed_sphere - bugfix: allocates heat_source when skeb is True and d_con is zero
@jkbk2004
Copy link
Collaborator

merged with #2278

@jkbk2004 jkbk2004 closed this Aug 12, 2024
@NeilBarton-NOAA NeilBarton-NOAA deleted the skeb_fix branch September 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants