-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for ufs-coastal app #2396
base: develop
Are you sure you want to change the base?
Modifications for ufs-coastal app #2396
Conversation
* the wave restarts are not b4b against the develop baseline but are b4b when compared against a baseline generated with the trho fix rt_atmwav_control_noaero_p8_intel.log: Comparing ufs.atmw.ww3.r.2021-03-22-64800 .....USING CMP......NOT IDENTICAL rt_hafs_regional_atm_wav_intel.log: Comparing ufs.hafs.ww3.r.2019-08-29-21600 .....USING CMP......NOT IDENTICAL
@DeniseWorthen Do you think that we need to find more meaningful aliases for the new fields defined in the dictionary. We could try to come up a set of standard names for them but not sure. Let me know what you think? |
@uturuncoglu I'm not sure how useful the aliases are if we have the description. So, for example we could make an alias for I do see now I should have probably named some of the new fields with "Fw" (as fluxes) and not "Sw" as states. |
@DeniseWorthen Yes, SCHSIM follows convention like that. See following part, https://github.com/oceanmodeling/schism-esmf/blob/12e2ce43475fe85212c60de7894524d22a1bab96/src/schism/schism_nuopc_cap.F90#L414. It is not big deal and I am using short names at this point for the implementation but we might consider to add aliases and use them in the SCHSIM side. anyway, I'll let you know when PR is ready in ufs coastal side. So, you could check it. |
I see, thanks. We definitely might need aliases then. |
@DeniseWorthen @JessicaMeixner-NOAA @janahaddad We had a meeting with costal team today. Here is our proposal,
Anyway, let me know what do you think about this plan. We are open any other suggestion at this point. |
@uturuncoglu I do think it is a good idea for Coastal to test the changes in the WW3 cap as much as possible while we wait for the stoppage of PRs in WW3 to lift. Also keep in mind that once the stoppage lifts, PRs to dev/ufs-weather-model will most likely be further delayed as community development (going to the develop branch) will also need to proceed. Also, I wanted to make Coastal aware of Issue NOAA-EMC/WW3#1298 in case you haven't seen it. |
@DeniseWorthen That is great. BTW, Thanks for pointing the PIO PR. |
Commit Queue Requirements:
Description:
Updates WW3 for modifications and fixes required by UFS-Coastal App
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Two tests will require updated baselines due to the bugfix for
trho(2)
in the wave restart file.Input data Changes:
Library Changes/Upgrades:
Testing Log: