Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add version pump" #7

Closed
wants to merge 3 commits into from
Closed

Revert "Add version pump" #7

wants to merge 3 commits into from

Conversation

a-ghanem
Copy link
Contributor

@a-ghanem a-ghanem commented Jan 4, 2022

Revert this because Dockerfile does not exist in the top-level directory. This is related to #4. If we remove the unused public broker we can redo this.

@a-ghanem a-ghanem requested a review from kjellp January 4, 2022 15:40
@a-ghanem a-ghanem changed the title Revert "Add version pump #major" Revert "Add version pump" Jan 4, 2022
kjellp
kjellp approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to fix the build and repo deploy setup :) Assume later work will complete the fix (and we should probably look closer at the need for us to maintain our own specialized localega-broker container or if we can standardize on a neicnordic version instead).

@a-ghanem a-ghanem closed this Feb 8, 2022
@a-ghanem a-ghanem deleted the revert-3-feature/version_pump branch February 8, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellp kjellp kjellp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-ghanem @kjellp