[WIP] fix misbehavior with trailing decimals #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset makes some of the earlier failing tests now succeed. But it triggers an assertion in s2d() and other newer tests fail.
|
Hmm, I'm not sure about this. It's definitely a problem if the code returns SUCCESS but an incorrect result. That part must be fixed. I was hoping to expand the code to handle arbitrary-length inputs (and that is not a small change). Handling a few additional (unnecessary) trailing zeros is nice to have, but I'm tempted to say that we should implement the arbitrary-length input case instead. Except for my lack of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix #181 . Not sure on the right way to go about it, so would be glad to have some early feedback.