Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member Saving Issues #18117

Open
bszyman opened this issue Jan 24, 2025 · 3 comments
Open

Member Saving Issues #18117

bszyman opened this issue Jan 24, 2025 · 3 comments
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug

Comments

@bszyman
Copy link

bszyman commented Jan 24, 2025

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.1

Bug summary

I'm noticing consistent buggy behavior when editing members in the Umbraco backoffice. Saves will fail with a generic "Unknown Error. Please see the log for more details" message.

I view the log, but don't see any entires out of the ordinary/related.

I notice that this issue also occurs in my v14 websites, too.

Specifics

Url: /umbraco/section/member-management/workspace/member/edit//invariant/view/info

I notice that if I toggle the "Approved" toggle to On, it'll save just as it should, all data is present.

Additionally, if I toggle "Approved" to on, save the member, browse away, and browse back, the toggle will be set back into an Off state again.

I haven't dug into the code, but I suspect that this toggle is required to be true by the backend api instead of allowing both false and true. Can't explain why it's not saving after it's be toggled to On, however.

Image

Image

Steps to reproduce

Navigate to the Members tab
Open a Member
Edit the value of a field and click Save.

Instead of saving, an error will show.

Navigate away and attempt to edit the same user with the same data, but before clicking Save, toggle the Approved toggle to an On state.

The member and data you entered will save successfully.

Expected result / actual result

The On or Off value for the "Approved" toggle in the member editor should persist properly to the database between editing sessions.

The PUT API method that gets called during save should accept false as a valid value for the isApproved field.

I'm in a bit of a cram at the moment, I'll look into this further when I'm freed up and see if I can create a fix and send it in a PR.

Copy link

Hi there @bszyman!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@AndyButland AndyButland added the state/needs-reproduction Check if this can be reproduced in the latest released version label Jan 27, 2025
@AndyButland
Copy link
Contributor

I'm afraid I've been unable to replicate this, running the latest code, which will be roughly equivalent to 15.2.0-rc. Seems I can save new and existing members irrespective of the setting of the "Approved" toggle. If you can find more about the exception that's being thrown in your case, please do share. Also if you are able to try out the 15.2.0-rc that would be useful too - possibly something has been fixed in that version that has resolved the error. That said, I have also rolled back the code to 15.1.2 and still don't see the error.

@jho-md
Copy link

jho-md commented Jan 28, 2025

We are also experiencing this issue on 15.1.2 when deploying to a live site. Saving a member locally throws no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug
Projects
None yet
Development

No branches or pull requests

3 participants