From 094d8ed084b2912d36e84251e9a2859d8dcc2b25 Mon Sep 17 00:00:00 2001 From: ll7 <32880741+ll7@users.noreply.github.com> Date: Fri, 6 Dec 2024 09:20:50 +0100 Subject: [PATCH] update project management and review guidelines to use TIP instead of INFO --- doc/development/project_management.md | 2 +- doc/development/review_guideline.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/development/project_management.md b/doc/development/project_management.md index ef5e45d7..ec772185 100644 --- a/doc/development/project_management.md +++ b/doc/development/project_management.md @@ -50,4 +50,4 @@ Merge the pull request after: After merging, remember to delete the source branch to keep the repository clean. ->[!INFO] For more information about the review process, see [Review process](./review_guideline.md). +>[!TIP] For more information about the review process, see [Review process](./review_guideline.md). diff --git a/doc/development/review_guideline.md b/doc/development/review_guideline.md index 840adb48..64a502c9 100644 --- a/doc/development/review_guideline.md +++ b/doc/development/review_guideline.md @@ -95,7 +95,7 @@ If a comment of a review was resolved by either, a new commit or a discussion be If a new commit took place it is encouraged to comment the commit SHA to have a connection between comment and resolving commit ![img.png](../assets/Resolve_conversation.png) -> [!INFO] All conversations should be resolved before merging the pull request. +> [!TIP] All conversations should be resolved before merging the pull request. ## 5. Merging a Pull Request @@ -120,7 +120,7 @@ Long story short, the reviewer who approves the PR should merge. Only approve if Before merging a pull request, the request checks by the CI/CD pipeline should be successful. If the checks fail, the pull request should not be merged. -> [!INFO] An exception can be made for a PR that only addresses the documentation and the `driving` check is not yet completed. +> [!TIP] An exception can be made for a PR that only addresses the documentation and the `driving` check is not yet completed. ### 5.3. Deleting the branch