From dee11ec1ee5b56df600665fa9a2e2de76322c758 Mon Sep 17 00:00:00 2001 From: JulianTrommer <46600808+JulianTrommer@users.noreply.github.com> Date: Thu, 7 Nov 2024 14:01:30 +0100 Subject: [PATCH 1/2] Added execution info for drive action --- doc/development/drive_action.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/doc/development/drive_action.md b/doc/development/drive_action.md index 08c93037..b5570002 100644 --- a/doc/development/drive_action.md +++ b/doc/development/drive_action.md @@ -2,19 +2,20 @@ **Summary:** This page explains the GitHub build action we use to evaluate our agent. -- [GitHub actions](#github-actions) - - [The drive job](#the-drive-job) - - [1. Checkout repository (`actions/checkout@v3`)](#1-checkout-repository-actionscheckoutv3) - - [2. Run agent with docker-compose](#2-run-agent-with-docker-compose) - - [3. Copy simulation results file out of container](#3-copy-simulation-results-file-out-of-container) - - [4. Stop docker-compose stack](#4-stop-docker-compose-stack) - - [5. Comment result in pull request `actions/github-script@v6`](#5-comment-result-in-pull-request-actionsgithub-scriptv6) - - [Simulation results](#simulation-results) +- [The drive job](#the-drive-job) + - [1. Checkout repository (`actions/checkout@v3`)](#1-checkout-repository-actionscheckoutv3) + - [2. Run agent with docker-compose](#2-run-agent-with-docker-compose) + - [3. Copy simulation results file out of container](#3-copy-simulation-results-file-out-of-container) + - [4. Stop docker-compose stack](#4-stop-docker-compose-stack) + - [5. Comment result in pull request `actions/github-script@v6`](#5-comment-result-in-pull-request-actionsgithub-scriptv6) +- [Simulation results](#simulation-results) ## The drive job The `drive` job is executed conditionally on `pull_request`, after the build successfully ran through. +> Warning: Always start the GitHub runner that handles the `drive` action through direct access to the machine. Do not use remote access like `ssh` or `xrdp`. + ### 1. Checkout repository ([`actions/checkout@v3`](https://github.com/actions/checkout)) Same step as in the [build job](#1-checkout-repository--actionscheckoutv3-) From 05ab21a71b90459398c6f0eca8cb1b1b6568d845 Mon Sep 17 00:00:00 2001 From: JulianTrommer <46600808+JulianTrommer@users.noreply.github.com> Date: Thu, 7 Nov 2024 14:17:41 +0100 Subject: [PATCH 2/2] Changed PR_ID env var --- .github/workflows/build.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 86c59e1b..b6682121 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -88,13 +88,11 @@ jobs: - name: Save pull request artifact if: github.event_name == 'pull_request' - env: - PR_ID: ${{ github.event.number }} run: | mkdir -p ./artifact printf '{ "is_pr": true, - "pr_id": $PR_ID + "pr_id": ${{ github.event.number }} }' >> ./artifact/artifact.json - name: Save merge artifact