Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Rework commit message hook #273

Closed
JulianTrommer opened this issue Jul 3, 2024 · 2 comments · Fixed by #297
Closed

[Feature]: Rework commit message hook #273

JulianTrommer opened this issue Jul 3, 2024 · 2 comments · Fixed by #297
Assignees
@ll7
Labels
discussion This issue needs to be discussed.
Milestone
Before WS24

Comments

@JulianTrommer
Copy link
Member

Description

See /build/config-comlipy.yml

Definition of Done

No response
@ll7 ll7 added the p2 label Aug 29, 2024
@ll7 ll7 mentioned this issue Aug 29, 2024
Closed
@ll7 ll7 added this to the Before WS24 milestone Sep 11, 2024
@ll7
Copy link
Member

ll7 commented Sep 23, 2024

The hooks are only installed if we continue to use b5.

https://github.com/una-auxme/paf23/blob/ad7767abb29fb9a78c2b2de152df3033dbe02fde/build/Taskfile#L18-L23

https://github.com/una-auxme/paf23/blob/ad7767abb29fb9a78c2b2de152df3033dbe02fde/build/Taskfile#L66-L70

Influences #274

@ll7 ll7 added the discussion This issue needs to be discussed. label Sep 23, 2024
@ll7
Copy link
Member

ll7 commented Sep 27, 2024

Comlipy feels a little bit outdated:
https://gitlab.com/slashplus-build/comlipy/
https://gitlab.com/slashplus-build/comlipy/tree/master/docs
https://gitlab.com/slashplus-build/comlipy/-/blob/master/docs/reference-rules.md

We could set the level to warning which corresponds to level 1.

@ll7 ll7 self-assigned this Sep 27, 2024
@ll7 ll7 mentioned this issue Sep 27, 2024
Merged
@ll7 ll7 linked a pull request Sep 27, 2024 that will close this issue
Update config-comlipy.yml to be only a warning #297
Merged
@ll7 ll7 closed this as completed in #297 Sep 27, 2024
@ll7 ll7 mentioned this issue Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ll7 ll7

Labels
discussion This issue needs to be discussed.
Projects
PAF Project Backlog
Archived in project
Milestone
Before WS24
Development

Successfully merging a pull request may close this issue.

Update config-comlipy.yml to be only a warning una-auxme/paf
2 participants
@ll7 @JulianTrommer