Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 - Update README.md #2

Merged
merged 1 commit into from
Nov 6, 2023
Merged

1 - Update README.md #2

merged 1 commit into from
Nov 6, 2023

Conversation

JulianTrommer
Copy link
Member

@JulianTrommer JulianTrommer commented Nov 6, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Time invested

Time invested by every contributor to this PR

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does this PR introduce a breaking change?

e.g. is old functionality not usable anymore

Most important changes

Which files functionalities are most important in this PR. On which part should the reviewer be focussed on?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@JulianTrommer JulianTrommer added the good first issue Good for newcomers label Nov 6, 2023
@JulianTrommer JulianTrommer requested a review from ll7 November 6, 2023 15:07
@JulianTrommer JulianTrommer self-assigned this Nov 6, 2023
@JulianTrommer JulianTrommer linked an issue Nov 6, 2023 that may be closed by this pull request
Copy link
Member

@ll7 ll7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, Julian! Most important PR so far!

@JulianTrommer JulianTrommer merged commit 6c0ff7b into main Nov 6, 2023
2 of 3 checks passed
@JulianTrommer JulianTrommer deleted the 1-feature-test-issue branch November 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature]: Test Issue
2 participants