Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #48 - Remove version tagging from build action #57

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Nov 14, 2023

Description

Removed automatic version tagging from build action, as it is not needed and caused issues - see the corresponding issue below.

Fixes #48

Authors: @samuelkuehnel @MaxJa4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

No, it fixes

Most important changes

Removed automatic version tagging from build action.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

This comment has been minimized.

@MaxJa4 MaxJa4 changed the title [Fix] Remove version tagging from build action [Fix] #48 - Remove version tagging from build action Nov 15, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that Build and push Docker image and Output Version do not require any information from the removed action?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag was required to build and push the docker image. We reverted our last change and updated the permission for this job. As a test we merged this branch and the desired action ran without an error:

image

https://github.com/una-auxme/paf23/actions/runs/6881744045/job/18718772391

@MaxJa4 MaxJa4 marked this pull request as draft November 15, 2023 11:20
@samuelkuehnel samuelkuehnel merged commit 50bb43e into main Nov 15, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the 48-push-tag-action-removal branch November 16, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Bump version and push tag fails.
3 participants