Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPR for GH actions #61

Merged
merged 4 commits into from
Nov 15, 2023
Merged

TestPR for GH actions #61

merged 4 commits into from
Nov 15, 2023

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Nov 15, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does this PR introduce a breaking change?

e.g. is old functionality not usable anymore

Most important changes

Which files functionalities are most important in this PR. On which part should the reviewer be focussed on?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

@MaxJa4 MaxJa4 changed the base branch from 48-push-tag-action-removal to main November 15, 2023 18:17
@MaxJa4 MaxJa4 closed this Nov 15, 2023
@MaxJa4 MaxJa4 reopened this Nov 15, 2023
@MaxJa4 MaxJa4 requested a review from samuelkuehnel November 15, 2023 18:20
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

Simulation results

Metric Value
Avg. driving score 0.008545
Avg. route completion 0.05
Avg. infraction penalty 0.297169
Collisions with pedestrians 0.297169
Collisions with vehicles 0.0
Collisions with layout 146.027
Red lights infractions 292.055
Stop sign infractions 0.0
Off-road infractions 0.0
Route deviations 0.003
Route timeouts 0.0
Agent blocked 292.055
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.0
Min speed infractions 292.055
undefined 0.0

@samuelkuehnel samuelkuehnel merged commit 197813b into main Nov 15, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the Test-PR-tag-building branch November 16, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants