Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

63 - Fix add-to-project action #90

Merged
merged 1 commit into from
Nov 23, 2023
Merged

63 - Fix add-to-project action #90

merged 1 commit into from
Nov 23, 2023

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Nov 23, 2023 •
edited
Loading

Description

Use existing GitHub token.
Fixes #63

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@MaxJa4 MaxJa4 changed the title Fix add-to-project action 63 - Fix add-to-project action Nov 23, 2023
@MaxJa4 MaxJa4 added bug Something isn't working infrastructure Docker, Project setup, ... labels Nov 23, 2023
@MaxJa4 MaxJa4 self-assigned this Nov 23, 2023
@MaxJa4 MaxJa4 requested a review from samuelkuehnel November 23, 2023 10:49
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
samuelkuehnel
samuelkuehnel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, why was this different anyway?
Did you find out what secrets.ADD_TO_PROJECT_PAT means?

@MaxJa4
Copy link
Collaborator Author

MaxJa4 commented Nov 23, 2023

nice fix, why was this different anyway? Did you find out what secrets.ADD_TO_PROJECT_PAT means?

I have no idea.
I suspect, that ADD_TO_PROJECT_PAT is either a placeholder from a example file or used to exist in the PAF22 repo. Since I don't have repo admin rights, I can't check. But the regular GITHUB_TOKEN should be fine.

@MaxJa4 MaxJa4 merged commit 0a10b0b into main Nov 23, 2023
3 checks passed
MaxJa4 added a commit that referenced this pull request Nov 23, 2023
@MaxJa4
Revert "Fix add-to-project action (#90)"
4c8a608 
This reverts commit 0a10b0b.
@MaxJa4 MaxJa4 mentioned this pull request Nov 23, 2023
Merged
MaxJa4 added a commit that referenced this pull request Nov 27, 2023
@MaxJa4
Revert "Fix add-to-project action (#90)" (#92)
f970b1c 
This reverts commit 0a10b0b.
@MaxJa4 MaxJa4 deleted the MaxJa4-patch-1 branch November 28, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkuehnel samuelkuehnel samuelkuehnel approved these changes

Assignees

@MaxJa4 MaxJa4

Labels
bug Something isn't working infrastructure Docker, Project setup, ...
Projects
PAF Project Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Workflow for Add-To-Project fails
2 participants
@MaxJa4 @samuelkuehnel