-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--pre is required to install alpha version of itkwidgets #50
Open
dzenanz
wants to merge
57
commits into
uncbiag:main
Choose a base branch
from
dzenanz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work with Python 3.12, as ITK 5.3 is not compiled for it. Python 3.11 or earlier is required.
thewtex
reviewed
Aug 29, 2024
@@ -785,7 +785,7 @@ | |||
"name": "python", | |||
"nbconvert_exporter": "python", | |||
"pygments_lexer": "ipython3", | |||
"version": "3.8.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay at 3.8, which has been tested for the ML deps.
This is more suitable for debugging, and is a step towards full automation
These intermediate files can also be used for inspection later.
Applying RAS to LPS transform to atlas_FC_inner_mesh_world.ply atlas_TC_inner_mesh_world.ply makes them properly aligned with the atlas image.
We need to do this because the atlas is in left knee orientation.
This has less artifacts, because the atlas mesh is smooth before transformation.
The 3D to 2D projection results in smoother projection with the original atlas mesh, which has staircase-like artifacts.
It already existed here: notebooks\OAIData\atlas_image.nii.gz
Originally I used the image normalization method from uniGradICON, assuming it is the same as what was used before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work with Python 3.12, as ITK 5.3 is not compiled for it.
Python 3.11 or earlier is required.