Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Page hero - tall" component should be made to accomodate longer words #1375

Open
theadamparker opened this issue Sep 13, 2024 · 0 comments
Open

"Page hero - tall" component should be made to accomodate longer words #1375

theadamparker opened this issue Sep 13, 2024 · 0 comments
Assignees
@theadamparker
Labels
design This issue requires design work before development can begin

Comments

@theadamparker
Copy link
Contributor

https://design.undp.org/?path=/story/components-ui-components-hero-page-pageherooption--page-hero-tall-image

In its current for longer words are wrapping. This is not a desirable behavior, and it should be redesigned.

Screenshot 2024-09-13 at 12 43 28 PM
@theadamparker theadamparker added the design This issue requires design work before development can begin label Sep 13, 2024
@theadamparker theadamparker self-assigned this Sep 13, 2024
Radu-Nicolae added a commit to networkinstitutevu/CFH-un-design-system that referenced this issue Sep 17, 2024
@Radu-Nicolae
(fix) issue undp#1375 -- header size dynamically adjusted
e82d792 
The size of the header is computed with a mathematical function and passed further to react. This way the header does not wrap around for single words that are long. However, it still wraps around for phrases.
@Radu-Nicolae Radu-Nicolae mentioned this issue Sep 18, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theadamparker theadamparker

Labels
design This issue requires design work before development can begin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theadamparker