Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fork lambda function to detect changes #29

Open
jag3773 opened this issue Sep 1, 2017 · 2 comments
Open

Update fork lambda function to detect changes #29

jag3773 opened this issue Sep 1, 2017 · 2 comments

Comments

@jag3773
Copy link
Contributor

jag3773 commented Sep 1, 2017

@neutrinog commented on Wed Jul 05 2017

The fork lambda will detect new repositories in the catalog organization however it would add a layer of redundancy if it also check if there were changes to the commits.

We would need to simply compare the recorded commit id with that of the latest in DCS.
This is blocked until the DCS api can be fixed to correctly return the branch information e.g. https://git.door43.org/api/v1/repos/Door43-Catalog/hi_ulb/branches

While logged into DCS the above api link works, however when not logged in gives a 401 response. Authentication should only be required to display sensitive information like email addresses or when the repository is private.


@neutrinog commented on Wed Jul 05 2017

I've updated the lambda to support checking for commit changes, however this will not actually work until the DCS api has been fixed.


@jag3773 commented on Thu Jul 06 2017

@ethantkoenig Are you aware of the bug @neutrinog referenced above? Is there a fix for it upstream?


@ethantkoenig commented on Thu Jul 06 2017

@jag3773 Not sure if it's a bug or requiring authentication was actually somebody's intent. I'll look into it.


@neutrinog commented on Thu Jul 27 2017

Just noting here that you can manually flag a repo as "dirty" within the aws console.
In the d43-catalog-in-progress table simply change the dirty key on an item to true. This will cause the fork lambda to re-fetch the repository.

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 1, 2017

@jag3773
Copy link
Contributor Author

jag3773 commented Sep 17, 2020

Probably not blocked anymore now that we are on Gitea 1.12, but the issue might not be relevant anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants