-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT Behavior #2935
Comments
Vanadium is GPL, we cannot just take their patches. |
its just a commit revert |
I've implemented a new setting to turn off JIT, but my patch is against mainline Chromium and I don't really have the time to sort out whether they will apply cleanly here or rebase them even if they don't... But if someone wants to do so, I'm fine with the BSD-3-clause license. |
@luke-jr What was the reasoning behind toggling |
Originally, Chromium had this option for JAVASCRIPT_JIT, but replaced it with JAVASCRIPT_OPTIMIZE when Webasm was released (details elided). When that happened, they cleared all the previous _JIT site overrides since users no longer had control over them. The workaround pref tells Chromium not to clear the overrides "again". In practice, everyone today probably already has it set - it's only useful if upgrading from an older version where the user has overrides already. (Which was the case when I first created these patches) |
Actually, since this is changing the setting default rather than assigning to it, it's entirely possible that I don't have it set still, and toggling it back would lose my own overrides😬 I'm not sure if others' similar patches (GrapheneOS has something like this too) would have the same methodology and thereby impact users' profiles |
It looks like disabling JIT only disables turbofan since a more recent version, perhaps we want to revert that change just as the Vanadium folks: GrapheneOS/Vanadium@09797bd
The text was updated successfully, but these errors were encountered: