-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patches/webgl: return generic info instead of empty strings #3217
patches/webgl: return generic info instead of empty strings #3217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dumbmoron
Are those strings generic enough? I mean, could it become a good fingerprinting point in the future? |
I was curious, so I tried to perform some analysis on vendor/renderer strings seen in the wild. I found this dataset: https://github.com/apify/fingerprint-suite/blob/master/packages/fingerprint-generator/src/data_files/fingerprint-network-definition.zip For reference, here are the results and code I used to analyze this dataset: https://gist.github.com/dumbmoron/bfa33483d9ea1b1c5ac08b5a281af46e |
While being less identifiable individually we were likely more identifiable as a group being the only browser that returned a blank string. This would at least help to blend in with legitimate values. It's also a good choice since it's platform-agnostic, that document mentioned windows 10 as an example but there's entries for other platforms such as linux for example. |
Equivalent to an unmerged PR [1], and should fix a youtube playback issue [2]. [1] ungoogled-software/ungoogled-chromium#3217 [2] ungoogled-software/ungoogled-chromium#3012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just merge this and do platform specific strings later?
I don't see any reason we'd want to make them more specific. It's better to keep them generic in order to reduce fingerprintability. |
ah oops, looks like I misread your previous comment |
Instead of returning empty strings for WebGL info, return a generic renderer & vendor taken from Windows 10 [1] [2].
Seemingly fixes #3012