Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22522 Remove -Wno-ambiguous-reversed-operator #2714

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

roubert
Copy link
Member

@roubert roubert commented Nov 30, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22522
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/intltest/pluralmaptest.cpp is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

@markusicu
Copy link
Member

... except we normally squash commits. You could just hoist the commit messages into the pull request and then squash, and merge.

@roubert
Copy link
Member Author

roubert commented Dec 4, 2023

... except we normally squash commits.

… when those commits are incremental changes.

@roubert roubert merged commit 394ebaa into unicode-org:main Dec 4, 2023
97 checks passed
@roubert roubert deleted the 22522-autoconf branch December 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants