Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General question regarding Temporal compatibility #4075

Closed
nekevss opened this issue Sep 22, 2023 · 3 comments
Closed

General question regarding Temporal compatibility #4075

nekevss opened this issue Sep 22, 2023 · 3 comments
Labels
R-as-designed Resolution: By design principles, this won't be fixed

Comments

@nekevss
Copy link
Contributor

nekevss commented Sep 22, 2023

Hi there! I was just wondering if there was any discussions on implementing CalendarFieldDescriptors and/or CalendarFieldKeysToIgnore from the Temporal proposal spec.

@sffc
Copy link
Member

sffc commented Sep 23, 2023

@hsivonen Is there another issue to track this?

@hsivonen
Copy link
Member

hsivonen commented Sep 25, 2023

@hsivonen Is there another issue to track this?

No, because I (perhaps incorrectly) thought that this stuff would be hard-coded as lists into the glue code.

@sffc
Copy link
Member

sffc commented Sep 26, 2023

Yeah, looking at this closer, this is in the gray area between what should be in ICU4X core versus what should be in the JS engine wrapper. However, I think the correct answer is to put it in the wrapper, because:

  1. The ICU4X calendar trait requires that all calendars speak the same language of era and month codes (https://docs.rs/icu_calendar/1.3.0/icu_calendar/trait.Calendar.html#tymethod.date_from_codes) so there is no additional information that ICU4X could provide by implementing these methods
  2. We decided in Where should month without year or monthCode be rejected? tc39/proposal-temporal#2664 to be consistent of the fields for all CLDR calendars.

I will therefore close this issue. Please comment if you think it should be re-opened.

@sffc sffc closed this as completed Sep 26, 2023
@sffc sffc added the R-as-designed Resolution: By design principles, this won't be fixed label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R-as-designed Resolution: By design principles, this won't be fixed
Projects
None yet
Development

No branches or pull requests

3 participants