Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make property name lookup get_loose more efficient and limit recursion depth #5599

Open
sffc opened this issue Sep 25, 2024 · 1 comment
Open

Make property name lookup get_loose more efficient and limit recursion depth #5599

sffc opened this issue Sep 25, 2024 · 1 comment
Labels
A-performance Area: Performance (CPU, Memory) C-unicode Component: Props, sets, tries good first issue Good for newcomers S-small Size: One afternoon (small bug fix or enhancement)
Milestone
Backlog ⟨P4⟩

Comments

@sffc
Copy link
Member

sffc commented Sep 25, 2024

Address some of the follow-ups in #5576.

CC @robertbastian
@sffc sffc added A-performance Area: Performance (CPU, Memory) C-unicode Component: Props, sets, tries labels Sep 25, 2024
@sffc sffc changed the title Make property name lookup get_loose more efficient Make property name lookup get_loose more efficient and limit recursion depth Sep 25, 2024
@sffc
Copy link
Member Author

sffc commented Sep 25, 2024

Additional observation: I don't think that these property names should ever have repeating whitespace characters. We should be able to use that property to limit recursion depth.

@Manishearth Manishearth added this to the Backlog ⟨P4⟩ milestone Jan 15, 2025
@Manishearth Manishearth added the S-small Size: One afternoon (small bug fix or enhancement) label Jan 15, 2025
@sffc sffc added the good first issue Good for newcomers label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-performance Area: Performance (CPU, Memory) C-unicode Component: Props, sets, tries good first issue Good for newcomers S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Milestone
Backlog ⟨P4⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth