Improve Cascading Cleanup #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spjmurray
force-pushed
the
better_cleanup
branch
from
616212e
to
02ff987
Compare
Servers need to be deleted before networks, networks before identities etc. Kubernetes provides this via cascading foregroud deletion and blocking owner deletion. This basically removes a bunch of code where we were doing this ourselves. While it works via the API, be damn sure you use `kubectl delete --cascade=foreground` via the CLI if ever needed. Implements #75
spjmurray
force-pushed
the
better_cleanup
branch
from
02ff987
to
70cffcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers need to be deleted before networks, networks before identities etc. Kubernetes provides this via cascading foregroud deletion and blocking owner deletion. This basically removes a bunch of code where we were doing this ourselves. While it works via the API, be damn sure you use
kubectl delete --cascade=foregroundvia the CLI if ever needed.