Add fuzzy-finder for project switching #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisPenner nice! I will definitely be using this. Would it be much effort and/or desirable to put the current project at the beginning (or end? Which is it?) of the list? My thought was that I'm often switching between |
aryairani
reviewed
Sep 12, 2023
| @@ -230,7 +230,7 @@ data Input | |||
| | DiffNamespaceToPatchI DiffNamespaceToPatchInput | |||
| | ProjectCreateI Bool {- try downloading base? -} (Maybe ProjectName) | |||
| | ProjectRenameI ProjectName | |||
| | ProjectSwitchI ProjectAndBranchNames | |||
| | ProjectSwitchI (Maybe ProjectAndBranchNames {- Nothing triggers fuzzy-finder -}) | |||
There was a problem hiding this comment.
Suggested change
| | ProjectSwitchI (Maybe ProjectAndBranchNames {- Nothing triggers fuzzy-finder -}) | |
| | ProjectSwitchI (Maybe ProjectAndBranchNames {- `Nothing` triggers fuzzy-finder -}) |
aryairani
reviewed
Sep 12, 2023
Comment on lines
+689
to
+708
| P.wrapColumn2 | ||
| [ ( P.sep | ||
| " " | ||
| [ backtick (P.sep " " [P.string cmd, "foo"]), | ||
| "removes the", | ||
| P.string target, | ||
| "name `foo` from the namespace." | ||
| ], | ||
| "" | ||
| ), | ||
| ( P.sep | ||
| " " | ||
| [ backtick (P.sep " " [P.string cmd, "foo bar"]), | ||
| "removes the", | ||
| P.string target, | ||
| "name `foo` and `bar` from the namespace." | ||
| ], | ||
| "" | ||
| ) | ||
| ] |
aryairani
approved these changes
Sep 12, 2023
|
Has a merge conflict now but otherwise looks good 😬 |
|
@ceedubs Okay I put the active project at the bottom :) I'll leave sorting by "frecency" for another day |
ChrisPenner
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds fuzzy-finder for
switchwithout any arguments which lists all project/branch pairs for you to search, whatever you select will be switched to.Implementation notes
Nothing, trigger a fuzzy-find to fill it in.fzfis killer fast, so should have no problem handling thousands of branches if it comes to that.Interesting/controversial decisions
Should it search projects, then search branches instead?
Test coverage
None