Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting on handle-with blocks #4671

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix formatting on handle-with blocks #4671

merged 1 commit into from
Feb 6, 2024

Conversation

ChrisPenner
Copy link
Contributor

Overview

Fixes #4666

handle x with y is getting formatted to handle x with y with y because the source-span was omitting the body of the handle.

Implementation notes

Include the body of the handle-with in its source span so it overwrites the whole thing when formatting.

Test coverage

Transcripts

@ChrisPenner ChrisPenner marked this pull request as ready for review February 5, 2024 18:47
@ChrisPenner ChrisPenner requested a review from aryairani February 5, 2024 18:54
Copy link
Contributor

@aryairani aryairani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@aryairani aryairani merged commit 4f345fe into trunk Feb 6, 2024
7 checks passed
@aryairani aryairani deleted the cp/format-handlers branch February 6, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic formatting adds spurious duplicate endings to terms
2 participants