Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Folding Ranges #4674

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Fix Folding Ranges #4674

merged 4 commits into from
Feb 6, 2024

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Feb 6, 2024

Overview

Quick one to upgrades the folding ranges feature to use the new binding-level span annotation which are more accurate.
Old folding ranges would sometimes fold awkwardly in the middle of type-annotations or below the actual start of bindings/watches

Implementation notes

  • Swap existing folding ranges to use the new top-level spans.
  • Adds a debug.folding-ranges helper which annotates the source annotations from the last parsed file.

Test coverage

Also adds debug.folding-ranges ucm command and transcripts which use it.

@ChrisPenner ChrisPenner requested a review from aryairani February 6, 2024 17:16
@ChrisPenner ChrisPenner marked this pull request as ready for review February 6, 2024 17:16
@ChrisPenner ChrisPenner self-assigned this Feb 6, 2024
@aryairani aryairani merged commit cf202fe into trunk Feb 6, 2024
7 checks passed
@aryairani aryairani deleted the cp/lsp-folding branch February 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants