Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Name ToJSONKey instance #4679

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add Name ToJSONKey instance #4679

merged 1 commit into from
Feb 8, 2024

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Feb 8, 2024 •
edited
Loading

Overview

Just an Orphan ToJSONKey instance allowing Share to use Names as JSON object keys.

Need it for namespace diffs on Share :D

@ChrisPenner ChrisPenner self-assigned this Feb 8, 2024
@ChrisPenner ChrisPenner requested a review from aryairani February 8, 2024 17:12
@aryairani aryairani merged commit 6a6b7b8 into trunk Feb 8, 2024
7 checks passed
@aryairani aryairani deleted the cp/namespace-diffs branch February 8, 2024 17:47
@ChrisPenner
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryairani aryairani aryairani approved these changes

Assignees

@ChrisPenner ChrisPenner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisPenner @aryairani