-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove update.old #5058
base: trunk
Are you sure you want to change the base?
Remove update.old #5058
Conversation
|
||
.a2> view A NeedsA f f2 f3 g | ||
|
||
type A a b c d | ||
= B b | ||
= A a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some re-ordering of constructor names here is strange, not sure if it's reason for concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm not sure either
unison-src/transcripts/propagate.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I patched this one up slightly, it was failing because builtins were out of scope.
73ee5e1
to
bad42b0
Compare
@@ -72,14 +73,15 @@ fromJust = "asldkfjasldkfj" | |||
```unison:hide | |||
fromJust = 99 | |||
b = "oog" | |||
bdependent = b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this as well to prevent update
from failing below.
6. yoohoo ┘ 7. yoohoo (removed) | ||
|
||
``` | ||
## Two different auto-propagated changes creating a name conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this block is something we don't care to test with update
bad42b0
to
897caac
Compare
897caac
to
9f71e2e
Compare
Just documenting that we have this on hold until people can use new |
I'm thinking that even though it may not strictly be necessary to wait, that we get known round trip errors taken care of and before removing |
Overview
Removes
update.old
in favour ofupdate
I've found myself rewriting a bunch of deprecated code for the project roots refactor, if it's reasonable to delete it it would be nice to do so now.
Implementation notes
update.old
andupdate.old.preview
handleUpdate
update.old
in transcripts ->update
Interesting/controversial decisions
There are a few concerns about whether
update.old
can be removed, specifically Rúnar ran into some round-trip failures due to misformatted ability lists.Test coverage
I updated the transcripts, I'd love if @mitchellwrosen could give them a look over though to ensure they still make sense.