bugfix: fix suffixification logic in update #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellwrosen
force-pushed
the
24-08-30-fix-update
branch
from
812130d to
e9c2d49
Compare
aryairani
approved these changes
Aug 30, 2024
mitchellwrosen
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The name suffixification logic in
updatewas not properly updated for the new parsing logic implemented in #5276. This PR fixes that.Test coverage
I've added a failing test in the first commit that is fixed by the second.