Codebase Server: remove the generated port and token

[hojberg]

Run the CodebaseServer with a default port and token as well as allowing UCM Desktop domains to perform CORS requests.

Keep the command line options to set a specific port, token, and add allow CORS domains.T

[ChrisPenner]

Looks good 👍🏼

Is there any documentation that needs updating as well?

[ChrisPenner]

P.s. looks like you need to remove cryptonite from the appropriate package now that it's not used as well :)

[aryairani]

Should we be making sure we're binding on localhost and not all interfaces? (iirc it was doing the the latter but I'm not able to check at the moment)

[hojberg]

@aryairani I think I'll need help sorting that out.

[aryairani]

@aryairani I think I'll need help sorting that out.

I'm learning too, but it looks like that's happening here:

unison/unison-share-api/src/Unison/Server/CodebaseServer.hs

Lines 461 to 465 in 3fcd4cb

	let baseUrl = BaseUrl (fromMaybe "http://127.0.0.1" (host opts)) token
	let settings =
	defaultSettings
	& maybe id setPort (port opts)
	& maybe id (setHost . fromString) (host opts)

defaultSettings allows connections on any IPv4 address, but I'm thinking we should use something like setHost "127.0.0.1" instead of id for when it's not specified in the CodebaseServerOpts, which I think comes from UCM_HOST.

But this raises a question. On line 465 we expect (host opts)/UCM_HOST to be an IP address etc., but on line 461 it looks like we expect it to be a URL. What's the semantic meaning of this variable supposed to be currently? cc @hojberg

[hojberg]

@aryairani ok this is ready for another look I think.