-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Management Console: coreconfig.go code understanding and improvement #465
Comments
To answer the questions:
|
thanks @jdrodjpl ! Would the next logical step be to just uncomment this and/or put a conditional flag around this (and have it default to run automatically)? If so, should we just turn this ticket into making that happen? |
Yeah, I think that makes sense. I'll do that and update the ticket. |
@jdrodjpl just checking in here. Is the auto-invoke part implemented? If not, it's okay. I just noticed the ticket status was not "in progress". There are probably bigger fish to fry anyway. |
The https://github.com/unity-sds/unity-management-console/blob/main/backend/internal/processes/coreconfig.go file needs to be commented and understood.
We want to be able to run the core config automatically, at least in certain default cases.
Understand what this code does, and add some high level comments, and formatting as necessary.
Also, answer these questions.
Is this the code that gets called when this button is pressed?
Is there a downside to having this run automatically?
What are the reasons why this would want to be run manually by a human?
How can we automatically invoke this?
The text was updated successfully, but these errors were encountered: