Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management Console: coreconfig.go code understanding and improvement #465

Open
galenatjpl opened this issue Aug 20, 2024 · 4 comments
Open
Assignees
Labels

Comments

@galenatjpl
Copy link
Collaborator

galenatjpl commented Aug 20, 2024

The https://github.com/unity-sds/unity-management-console/blob/main/backend/internal/processes/coreconfig.go file needs to be commented and understood.
We want to be able to run the core config automatically, at least in certain default cases.
Understand what this code does, and add some high level comments, and formatting as necessary.

Also, answer these questions.

  1. Is this the code that gets called when this button is pressed?
    Image

  2. Is there a downside to having this run automatically?

  3. What are the reasons why this would want to be run manually by a human?

  4. How can we automatically invoke this?

@galenatjpl galenatjpl converted this from a draft issue Aug 20, 2024
@jdrodjpl
Copy link

To answer the questions:

  1. Yes, this is the code that kicks off when you hit the "Save" button.

  2. At the present, I don't think so. It looks like the Project and Venue values use to be editable but were disabled in the frontend, probably because now we need to define that stuff much earlier in order to set up the proxy, etc. The subnets seem to me like something that we probably don't want people to mess with, and I can't find any examples of how the optional parameters are actually being used by the MC code.

  3. I suppose that if establishing MC-wide parameters is something that we want to do at some point, a process like this would be useful. But right now, especially given that none of the fields here are really things that we want people to edit (right?), it seems like kind of a superfluous extra step.

  4. Pretty easily -- this used to be invoked during the bootstrap but that part was commented out at some point.

@galenatjpl
Copy link
Collaborator Author

thanks @jdrodjpl ! Would the next logical step be to just uncomment this and/or put a conditional flag around this (and have it default to run automatically)? If so, should we just turn this ticket into making that happen?

@jdrodjpl
Copy link

Yeah, I think that makes sense. I'll do that and update the ticket.

@galenatjpl
Copy link
Collaborator Author

@jdrodjpl just checking in here. Is the auto-invoke part implemented? If not, it's okay. I just noticed the ticket status was not "in progress". There are probably bigger fish to fry anyway.

@galenatjpl galenatjpl moved this to In Progress in Unity Project Board Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

2 participants