univention-samba4-backup: don't touch backups every day #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SvenRoederer
force-pushed
the
univention-samba4-backup
branch
from
2d3b5e8 to
59b5fa7
Compare
JuergenBS
reviewed
Jun 28, 2024
The backups get their permissions changed every time the script is running. This changes the ctime of the file and causes inclusion to systembackups (e.g. bareos). This is especially annoying when many backupfiles are kept or the files are large. In f065824 calling "chmod" for every files was added, now we do it only for files with wrong permissions.
SvenRoederer
force-pushed
the
univention-samba4-backup
branch
from
59b5fa7 to
3ad26b4
Compare
|
updated the Code as suggested by @JuergenBS |
|
@JuergenBS ping - Any update? |
|
Thanks for the ping and the improvement suggestion, we'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you considered the following things
Link to the issue in Bugzilla
https://forge.univention.org/bugzilla/show_bug.cgi?id=57409
Description of the changes
The backups get their permissions changed every time the script is running. This changes the ctime of the file and causes inclusion to systembackups (e.g. bareos). This is especially annoying when many backupfiles are kept or the files are large.
This change uses find to only change the permission, where they are not as expected.
Tested with UCS-5.0-8