Add --stop-after
parameter to unoserver
#144
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
unoserver
as a long-running service, it is often useful to restart bothunoserver
and LibreOffice after a certain number of requests (e.g. 1,000), so that any potential bad state is reset and any potential misallocated memory in LibreOffice is freed.This PR adds the parameter
--stop-after
tounoserver
:--stop-after
: Terminate Libreoffice and exit after the given number of requests.Demonstation
Here is a demonstration of using the new parameter.
First, we spin up a Docker container with Ubuntu, LibreOffice, Python, and the code from this PR:
Next, we download an example DOCX file and we launch
unoserver
with the parameter--stop-after 5
:Finally, from the outside of the container, we launch 5 conversions:
Meanwhile, in the container, we can see that
unoserver
has exited with a zero exit code after the fifth conversion: