Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Checking #7

Open
gcohen55 opened this issue Mar 21, 2015 · 1 comment
Open

Version Checking #7

gcohen55 opened this issue Mar 21, 2015 · 1 comment

Comments

@gcohen55
Copy link

While, off the top of my head, I can't think of anything that can break between versions sense, especially since we're using pkg, I still figure that we should allow installation only on "supported" versions of software that we've tested on.

Since there will be multiple versions of pfSense, we should have a list of supported versions, run the version of pfSense that the script is running on by that list. If the version isn't supported, quit.

We should also give the user an option ( perhaps defined by ENV variable )

SKIP_VERSION_CHECK="true" curl .... | /bin/sh -s 
@gozoinks
Copy link
Collaborator

It's a good idea, as long as we're relying only on the script.

Of course, the package itself will handle a lot of this for us, if and when we have this implemented in PHP for the actual pfsense package manager.

If there is little that can break between versions of pfSense, then this seems like a low priority for this particular project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants