Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commerce] [Cart] Elements missing in the Xaml #738

Open
rajamatt opened this issue Jun 5, 2024 · 0 comments
Open

[Commerce] [Cart] Elements missing in the Xaml #738

rajamatt opened this issue Jun 5, 2024 · 0 comments

Comments

@rajamatt
Copy link
Contributor

rajamatt commented Jun 5, 2024

  1. Quantity of items in the cart can't be changed, the "More" and "Less" commands are never bound to in the Xaml
  2. Items can't be removed from the cart because the "Remove" command is never bound to in the Xaml

see:

public async ValueTask Remove(CartItem item, CancellationToken ct)
=> await CartService.Remove(item.Product, ct);
public async ValueTask More(CartItem item, CancellationToken ct)
=> await CartService.Update(item.Product, item.Quantity + 1, ct);
public async ValueTask Less(CartItem item, CancellationToken ct)
=> await CartService.Update(item.Product, item.Quantity - 1, ct);

  1. Number of items in cart is hardcoded

@rajamatt rajamatt changed the title [Commerce] [Cart] Commands missing in the Xaml [Commerce] [Cart] Elements missing in the Xaml Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant