Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple indexes #36

Open
chammaaomar opened this issue Apr 18, 2023 · 2 comments
Open

Support multiple indexes #36

chammaaomar opened this issue Apr 18, 2023 · 2 comments

Comments

@chammaaomar
Copy link

Currently only a single possible index is support, due to the global variable index in adapter.ts. It would be helpful if getSearchClient could take an index parameter. It currently looks like it does, since it takes the parameter newIndex?: any, but this newIndex is only used as index || newIndex, so if there's an existing index, newIndex ignored. Not sure if that's intentional. Hope my issue is clear. Thanks for developing and maintaining this library.

@Ruitjes
Copy link
Collaborator

Ruitjes commented Apr 26, 2023

Hi @chammaaomar thank you for using the package. As it has been a while since I last worked on the library, I am not sure if it was done intentional or not. I currently do not have the time to test or make any updates. I suggest that you consider implementing support for multiple indexes yourself and submitting a pull request for review. This would be the best way forward.

@chammaaomar
Copy link
Author

No worries, thank you for the response. I'll look into and hopefully get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants