Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broccoli-dist-es6-module#mattia #9

Open
givanse opened this issue Nov 27, 2014 · 3 comments
Open

broccoli-dist-es6-module#mattia #9

givanse opened this issue Nov 27, 2014 · 3 comments

Comments

@givanse
Copy link
Contributor

givanse commented Nov 27, 2014

Couldn't the project have the custom files within itself instead of depending on the customization of another package? I'm talking about:

git+https://github.com/ghedamat/broccoli-dist-es6-module#mattia/use-main-name-for-all-builds

Say, I want to add the repository field to avoid the ugly warnings:

npm WARN package.json [email protected] No repository field.

I don't want to customize the customization of a dependency.

@givanse givanse changed the title npm install doesn't work properly out of the box broccoli-dist-es6-module#mattia Nov 27, 2014
@ghedamat
Copy link
Member

@givanse we're a few months late here :/ sorry!

somehow I didn't get any of these notifications.

we could probably do that you suggest, we use a customized version of broccoli-dist-es6-module because the original version was left unmantained and we needed that particular feature

I guess we could copy the source within our project and remove the dependency altogether. although at this point I think it would be best to spend the time and port this whole project to an ember-cli addon

@givanse
Copy link
Contributor Author

givanse commented May 26, 2015

Yep, time has passed and an addon its probably the best route now.

@givanse
Copy link
Contributor Author

givanse commented May 26, 2015

If the addon route is taken, tip: make two addons, one for the calendar component and another one for the CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants