libtiff-dev and is missing from package.xml for noetic

[kjeremy]

No description provided.

[amock]

Indeed libtiff-dev is missing (fixed with PR #22 ). However, lz4 seems to be already existing in all branches. @kjeremy , could you specify the exact branch/tag/commit you are using?

[kjeremy]

Thanks for fixing this with libtiff-dev!

Looking back on this I think I misspoke with lz4. It does appear to be specified correctly. I had to modify the build logic for nixos so that the package could find lz4: lopsided98/nix-ros-overlay@2de811f and that's probably when I thought the package wasn't specified.

[amock]

Hi @kjeremy ,

I saw you added a post script that changed some of the variables set by the custom lz4 find script. We recently had some problems with some of the custom cmake-find scripts as well. So I changed the lz4 find-package script to use cmake's PkgConfig which I guess is currently the correct way of integrating lz4 into a cmake projects. I don't know whether it effects your nix build. Perhaps you can even remove the postPatch instructions after our changes.