Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove vtk #24

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fix/remove vtk #24

merged 3 commits into from
Oct 18, 2024

Conversation

Cakem1x
Copy link
Contributor

@Cakem1x Cakem1x commented Oct 16, 2024

This PR makes VTK optional when finding packages for LVR2's dependencies.

This change should fix the build issues in naturerobots/mesh_tools#45 and naturerobots/mesh_navigation#63.
I managed to reproduce the build failure from mesh_tools on my local machine (after removing VTK). With the change in this PR, I can build it on my machine without VTK (I get only warnings, no error anymore).

--- stderr: hdf5_map_io
CMake Warning at /home/docker/ros_ws/install/lvr2/lib/cmake/lvr2/LVR2Config.cmake:73 (find_package):
  By not providing "FindVTK.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "VTK", but
  CMake did not find one.

  Could not find a package configuration file provided by "VTK" with any of
  the following names:

    VTKConfig.cmake
    vtk-config.cmake

  Add the installation prefix of "VTK" to CMAKE_PREFIX_PATH or set "VTK_DIR"
  to a directory containing one of the above files.  If "VTK" provides a
  separate development package or SDK, be sure it has been installed.

Cakem1x and others added 3 commits August 6, 2024 11:24
Sync humble branch with upstream
VTK is only needed when building the viewer (disabled by default)
@Cakem1x Cakem1x marked this pull request as ready for review October 16, 2024 14:15
@amock
Copy link
Member

amock commented Oct 18, 2024

Looks good :)
Note for myself: Check if VTK has to be changed to required if certain optional targets are build. (e.g. lvr2_viewer)

@amock amock merged commit 2554799 into uos:humble Oct 18, 2024
2 checks passed
@Cakem1x Cakem1x deleted the fix/remove-vtk branch October 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants