Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resolving ProviderConfig references #37

Open
negz opened this issue Apr 9, 2021 · 0 comments · Fixed by #40
Open

Add support for resolving ProviderConfig references #37

negz opened this issue Apr 9, 2021 · 0 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request

Comments

@negz
Copy link
Member

negz commented Apr 9, 2021

Edit: #40 removed support for resolving ProviderConfig references per the details below. I'm repurposing this issue to track adding them back once crossplane/crossplane#2255 is solved.

What problem are you facing?

Per crossplane/crossplane#2255 it's challenging for xgql to resolve a managed resource's spec.providerConfigRef because we need to do a bunch of spelunking to figure out which provider a managed resource belongs to.

How could xgql help solve your problem?

I think the right way to solve this is to have Crossplane give us the information we need. In the meantime, we should consider removing support for resolving a managed resource's provider config from the schema. We could still expose the information as an unresolved reference in the meantime, though doing so would be a little unidiomatic for xgql.

@negz negz added the enhancement New feature or request label Apr 9, 2021
@negz negz self-assigned this Apr 11, 2021
@negz negz closed this as completed in #40 Apr 11, 2021
@negz negz reopened this Apr 11, 2021
@negz negz changed the title Remove schema support for resolving ProviderConfig references (for now) Add support for resolving ProviderConfig references Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant