Using a single layout reference

uqbar-project · Nov 24, 2023 · 6c27d44 · 6c27d44
1 parent e1c8c92
commit 6c27d44
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/public/diagram/diagram.js b/public/diagram/diagram.js
@@ -1,5 +1,6 @@
 let cy
 let currentElements = []
+let layout
 
 function initializeCytoscape(container) {
   const fontFace = {
@@ -107,23 +108,15 @@ function initializeCytoscape(container) {
       },
     ],
   })
-}
-
-function updateLayout() {
-  updateNodes(cy.elements())
-}
 
-function updateNodes(elements) {
-  const layout = elements.layout({
+  layout = cy.layout({
     name: "cose",
     animate: false,
     nodeDimensionsIncludeLabels: true,
     fit: true,
     nodeOverlap: 4,
     randomize: false,
   })
-
-  layout.run()
 }
 
 function objectsPositionChanged() {
@@ -142,13 +135,8 @@ function reloadDiagram(elements) {
   cy.filter((element) => !ids.includes(element.id())).remove()
   const newElements = elements.filter((element) => !cy.hasElementWithId(element.data.id))
   if (newElements.length) {
-    const shouldUpdateLayout = !objectsKeepTheirPosition() || cy.elements().length === 0
-    const addedNodes = cy.add(newElements)
-    if (shouldUpdateLayout) {
-      updateLayout()
-    } else {
-      updateNodes(readyForLayoutElems(addedNodes))
-    }
+    cy.add(newElements)
+    layout.run()
   }
 }