Смирнов Алексей #36
Open
Смирнов Алексей #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
|
В целом ок. Хочется еще увидеть:
|
|
🍅 |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
FrodoTheTrue
reviewed
Nov 1, 2016
| column-rule: 1px solid rgba(0,0,0, .5); | ||
| -moz-column-rule: 1px solid rgba(0,0,0, .5); | ||
| -webkit-column-rule: 1px solid rgba(0,0,0, .5); | ||
| hyphens: auto; | ||
| break-inside: avoid-page; | ||
| } | ||
|
|
||
| .post-2 | ||
| { | ||
| column-count: 3; |
There was a problem hiding this comment.
безвендорное правило должно идти после
|
Стало лучше, хочется еще увидеть картинку на несколько стобцов |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
|
В мозиле совсем разломалось |
FrodoTheTrue
reviewed
Nov 2, 2016
| <header> | ||
| <h1 class="headline">USA TODAY</h1> | ||
| <aside class="weather"><span class="vertical">Weather</span> | ||
| <img src="image/d.sun.png" alt="sun">+12</aside> |
|
🍅 |
FrodoTheTrue
reviewed
Nov 2, 2016
| height: 140px; | ||
| } | ||
|
|
||
| div |
There was a problem hiding this comment.
привязываться к тегам обычно плохая практика, а к диву особенно нехорошо
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотреть решение