Крылосова Валерия #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2017 18:26
zmenka
requested changes
May 17, 2017
| } | ||
| var now = new Date(); | ||
| var date = new Date(date); | ||
| var dateTime = date.toLocaleTimeString('ru-RU', |
There was a problem hiding this comment.
new Date('2017-04-25T22:09:10.609Z').toLocaleTimeString('ru-RU',{ hour: '2-digit', minute: '2-digit', hour12: false}) вывело "3:09", так что ноль в начале не подставляется
| body.forEach(function(item, i, body) { | ||
| //date = formatDate(item['created_at']) | ||
| //console.log(date + '\n' + item['text'] + '\n' + ' '); | ||
| console.log('1') |
There was a problem hiding this comment.
кажется нужное закомментировано)
| } | ||
| catch(err){ | ||
| throw err; | ||
| }} |
There was a problem hiding this comment.
Можно убрать try catch, var date = () => formatDate('23 марта') точно также сработает
| console.log(error) | ||
| } | ||
| else{ | ||
| body = JSON.parse(body) |
There was a problem hiding this comment.
здесь можно добавить try catch, тогда сможем отличить ошибку при получении запроса от ошибки некорректного json-a, и можно будет это протестить
| // Напишите код форматирования даты в этом месте | ||
| } | ||
| var now = new Date(); | ||
| var date = new Date(date); |
There was a problem hiding this comment.
А если от api не придет дата? Тогда var date = new Date(date); вернет текущее время, а это некорректное поведение
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.