Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Rails 6 #8

Open
packerbacker89 opened this issue Aug 6, 2019 · 2 comments
Open

Deprecation warning with Rails 6 #8

packerbacker89 opened this issue Aug 6, 2019 · 2 comments

Comments

@packerbacker89
Copy link

Using caracal-rails with Rails 6 leads to the following deprecation warning:

DEPRECATION WARNING: Single arity template handlers are deprecated. Template handlers must
now accept two parameters, the view object and the source for the view object.
Change:
  >> Caracal::Rails::TemplateHandler.call(template)
To:
  >> Caracal::Rails::TemplateHandler.call(template, source)
@dwood-somniainc
Copy link

Yup. I get this error in my testing suite all of the time. Hopefully, he'll be able to update it soon.

@spovich
Copy link

spovich commented Jun 22, 2020

This is a one-liner fix in this PR: #12

Verified this fixes the issue. Any chance of a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants