From 39d00d9772fd4201f7bb79971fbe86a7d5b05e3d Mon Sep 17 00:00:00 2001
From: Cheng Yuan <84340069+chengyuan0124@users.noreply.github.com>
Date: Thu, 31 Aug 2023 16:27:34 -0400
Subject: [PATCH] Added comment

---
 .../resources/scenarios/Barnim/ns3/ns3_federate_config.xml | 7 ++++++-
 .../scenarios/Tiergarten/ns3/ns3_federate_config.xml       | 7 ++++++-
 .../resources/scenarios/Town04/ns3/ns3_federate_config.xml | 7 ++++++-
 .../scenarios/Town04_test/ns3/ns3_federate_config.xml      | 7 +++++++
 4 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/co-simulation/bundle/src/assembly/resources/scenarios/Barnim/ns3/ns3_federate_config.xml b/co-simulation/bundle/src/assembly/resources/scenarios/Barnim/ns3/ns3_federate_config.xml
index 473010ef..6cf70119 100644
--- a/co-simulation/bundle/src/assembly/resources/scenarios/Barnim/ns3/ns3_federate_config.xml
+++ b/co-simulation/bundle/src/assembly/resources/scenarios/Barnim/ns3/ns3_federate_config.xml
@@ -73,7 +73,12 @@
 
  <default name="ns3::ConstantRateWifiManager::DataMode" value="OfdmRate6Mbps"/>
  <default name="ns3::ConstantRateWifiManager::ControlMode" value="OfdmRate6Mbps"/>
-
+ <!-- 
+    Fabian Eckermann NS-3 C-V2X cannot take ns3::QueueBase::MaxPackets 
+    configuration. By removing this config, the default setting will be 
+    unbounded. Without a set limit on MaxPackets, the queue would not drop 
+    packets solely because it has exceeded a specified packet count. 
+ -->
  <!-- <default name="ns3::QueueBase::MaxPackets" value="400"/> -->
  <default name="ns3::WifiMacQueue::MaxDelay" value="+500000000.0ns"/>
  <default name="ns3::WifiNetDevice::Mtu" value="2296"/>
diff --git a/co-simulation/bundle/src/assembly/resources/scenarios/Tiergarten/ns3/ns3_federate_config.xml b/co-simulation/bundle/src/assembly/resources/scenarios/Tiergarten/ns3/ns3_federate_config.xml
index 5c0c05e3..8c291b97 100644
--- a/co-simulation/bundle/src/assembly/resources/scenarios/Tiergarten/ns3/ns3_federate_config.xml
+++ b/co-simulation/bundle/src/assembly/resources/scenarios/Tiergarten/ns3/ns3_federate_config.xml
@@ -73,7 +73,12 @@
 
  <default name="ns3::ConstantRateWifiManager::DataMode" value="OfdmRate6Mbps"/>
  <default name="ns3::ConstantRateWifiManager::ControlMode" value="OfdmRate6Mbps"/>
-
+ <!-- 
+    Fabian Eckermann NS-3 C-V2X cannot take ns3::QueueBase::MaxPackets 
+    configuration. By removing this config, the default setting will be 
+    unbounded. Without a set limit on MaxPackets, the queue would not drop 
+    packets solely because it has exceeded a specified packet count. 
+ -->
  <!-- <default name="ns3::QueueBase::MaxPackets" value="400"/> -->
  <default name="ns3::WifiMacQueue::MaxDelay" value="+500000000.0ns"/>
  <default name="ns3::WifiNetDevice::Mtu" value="2296"/>
diff --git a/co-simulation/bundle/src/assembly/resources/scenarios/Town04/ns3/ns3_federate_config.xml b/co-simulation/bundle/src/assembly/resources/scenarios/Town04/ns3/ns3_federate_config.xml
index 473010ef..6cf70119 100644
--- a/co-simulation/bundle/src/assembly/resources/scenarios/Town04/ns3/ns3_federate_config.xml
+++ b/co-simulation/bundle/src/assembly/resources/scenarios/Town04/ns3/ns3_federate_config.xml
@@ -73,7 +73,12 @@
 
  <default name="ns3::ConstantRateWifiManager::DataMode" value="OfdmRate6Mbps"/>
  <default name="ns3::ConstantRateWifiManager::ControlMode" value="OfdmRate6Mbps"/>
-
+ <!-- 
+    Fabian Eckermann NS-3 C-V2X cannot take ns3::QueueBase::MaxPackets 
+    configuration. By removing this config, the default setting will be 
+    unbounded. Without a set limit on MaxPackets, the queue would not drop 
+    packets solely because it has exceeded a specified packet count. 
+ -->
  <!-- <default name="ns3::QueueBase::MaxPackets" value="400"/> -->
  <default name="ns3::WifiMacQueue::MaxDelay" value="+500000000.0ns"/>
  <default name="ns3::WifiNetDevice::Mtu" value="2296"/>
diff --git a/co-simulation/bundle/src/assembly/resources/scenarios/Town04_test/ns3/ns3_federate_config.xml b/co-simulation/bundle/src/assembly/resources/scenarios/Town04_test/ns3/ns3_federate_config.xml
index 473010ef..ef5650e2 100644
--- a/co-simulation/bundle/src/assembly/resources/scenarios/Town04_test/ns3/ns3_federate_config.xml
+++ b/co-simulation/bundle/src/assembly/resources/scenarios/Town04_test/ns3/ns3_federate_config.xml
@@ -74,7 +74,14 @@
  <default name="ns3::ConstantRateWifiManager::DataMode" value="OfdmRate6Mbps"/>
  <default name="ns3::ConstantRateWifiManager::ControlMode" value="OfdmRate6Mbps"/>
 
+ <!-- 
+    Fabian Eckermann NS-3 C-V2X cannot take ns3::QueueBase::MaxPackets 
+    configuration. By removing this config, the default setting will be 
+    unbounded. Without a set limit on MaxPackets, the queue would not drop 
+    packets solely because it has exceeded a specified packet count. 
+ -->
  <!-- <default name="ns3::QueueBase::MaxPackets" value="400"/> -->
+ 
  <default name="ns3::WifiMacQueue::MaxDelay" value="+500000000.0ns"/>
  <default name="ns3::WifiNetDevice::Mtu" value="2296"/>